https://bugzilla.wikimedia.org/show_bug.cgi?id=40088

       Web browser: ---
             Bug #: 40088
           Summary: [GraphViz] graphsize parameter not validated properly.
           Product: MediaWiki extensions
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Unprioritized
         Component: SemanticResultFormats
        AssignedTo: [email protected]
        ReportedBy: [email protected]
                CC: [email protected], [email protected]
    Classification: Unclassified
   Mobile Platform: ---


My diff utility doesn't seem to be working right (probably some crap with line
endings or something), but whatever.

MediaWiki 1.19.1
PHP 5.3.10-1ubuntu3.2 (apache2handler)
MySQL 5.5.24-0ubuntu0.12.04.1
SMW 1.8alpha
SF 2.4.2
SRF 1.8alpha (treeish b1cc82096e)

 The "graphsize" parameter isn't handled correctly, I guess.  You got this:

$params['graphsize'] = new Parameter( 'graphsize', Parameter::TYPE_INTEGER );

around about line 293 of formats/graphviz/SRF_Graph.php.  Doesn't work.  Gonna
have a bad time.  All your nodes are great size.  Bad for netbooks.  Bad for
America.

This:

$params['graphsize'] = new Parameter( 'graphsize', Parameter::TYPE_STRING, '');

works better.  Something to do with the pointf not being an integer but an
ordered pair.  Also, you can remove the li'l

$params['graphsize']->setDefault( '', false );

line.

Now it's good.  Looks pretty.  Good for you.  Good for me.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to