https://bugzilla.wikimedia.org/show_bug.cgi?id=24700

Krinkle <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #5 from Krinkle <[email protected]> 2012-09-11 02:08:18 UTC ---
(In reply to comment #4)
> At the moment the form is POSTed to /wiki/Special:Preferences. The server
> answers with 302 and redirects to
> /wiki/index.php?title=Special:Preferences&success=1
> 
> The server should answer with the preferences page with success box directly 
> on
> the POST request.

No, it should not. This is PRG[1], that is by design and on purpose with a
redirect at the end.

The resulting page shows the preferences page, which should be a permalink to
that. Refreshing manually or by a browser recovery should not re-submit the
(potentially outdated) form information.

What could be done instead is write a core js module (always loaded) that
submits through javascript. That way the submission does not occupy the browser
window and the url never has to include "success=1". Instead, the callback
handler would put up that message programmatically (probably through mw.notify,
while at it).

As fallback for non-javascript it can stay as is (though it could be improved).

[1] https://en.wikipedia.org/wiki/Post/Redirect/Get

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to