https://bugzilla.wikimedia.org/show_bug.cgi?id=40295

Daniel Kinzler <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #1 from Daniel Kinzler <[email protected]> 2012-09-17 
18:14:02 UTC ---
The intention was to allow an item that was already stored in the database (and
thus has an ID) to be equal to a newly created "volatile" item that doesn't
have an ID.

Using a different function for this kind of comparison is cleaner - I was
trying to make this opaque to the caller, but that was probably a silly idea.
So, I agree that we should go this route, but I would really like to have
descriptive names. Between "equals" and "same", it's kind of non-obvious which
does which. So, how about equals() for "total" equality and hasSameContent()
for the version that ignores the ID?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to