https://bugzilla.wikimedia.org/show_bug.cgi?id=40415

       Web browser: ---
             Bug #: 40415
           Summary: Add missing dependencies for modules "mediawiki.user"
                    and "mediawiki.action.view.dblClickEdit"
           Product: MediaWiki
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Keywords: javascript
          Severity: normal
          Priority: Unprioritized
         Component: ResourceLoader
        AssignedTo: [email protected]
        ReportedBy: [email protected]
                CC: [email protected], [email protected],
                    [email protected]
    Classification: Unclassified
   Mobile Platform: ---


I think the module "mediawiki.user"
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=resources/Resources.php;h=5156dd04374d2f4c53582833d5bf32ce1dcb316d;hb=HEAD#l624
should have "user.tokens" as dependecy because of this line:
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=resources/mediawiki/mediawiki.user.js#l249
 249         mw.user = new User( mw.user.options, mw.user.tokens );


Also, the module
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=resources/mediawiki.action/mediawiki.action.view.dblClickEdit.js
uses mw.util.$content, so it should have 'mediawiki.page.startup' as
dependency:
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=resources/Resources.php;h=5156dd04374d2f4c53582833d5bf32ce1dcb316d;hb=HEAD#l661

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to