https://bugzilla.wikimedia.org/show_bug.cgi?id=40481

       Web browser: ---
             Bug #: 40481
           Summary: UI giving fatal error when trying to mark certain
                    edits as patrolled. (en.wikt)
           Product: MediaWiki
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: Patrolling
        AssignedTo: [email protected]
        ReportedBy: [email protected]
                CC: [email protected], [email protected]
    Classification: Unclassified
   Mobile Platform: ---


On the English Wiktionary, when I click a "Mark as patrolled" link for some
edits, I get a fatal error with these details:

> PHP fatal error in 
> /usr/local/apache/common-local/php-1.20wmf12/includes/Message.php line 605:
> Call to a member function getText() on a non-object

Observations:

- The error prevents the edit from being marked as patrolled. (Furthermore, the
UI error-message persists even after an edit is marked as patrolled via the API
-- more on that below -- so the error must be taking place before the UI even
gets to the point of trying to mark the edit as patrolled.)

- This seems to be tied to the specific edit: the majority of edits do not
trigger this error, but if an edit *does* trigger this error, it will do so
consistently: every time I visit its mark-as-patrolled page, I get the same
error.

- I haven't observed a pattern to which edits are affected, but if anyone
offers a predictive theory, I can try to confirm or refute it.

- This problem does *not* affect the mark-as-patrolled API call. This offers a
partial workaround, since we have site JavaScript that creates
mark-as-patrolled buttons in various places, and those buttons use the API
rather than the UI; but still, but it's not always very easy to get to one of
those places to find the button for a specific edit that you've tried and
failed to mark as patrolled.

- This is *not* caused by expiring patrol-tokens. If I reload the page that
contains the "Mark as patrolled" link, it will continue to give me a link that
uses the same patrol-token.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to