https://bugzilla.wikimedia.org/show_bug.cgi?id=38822

--- Comment #5 from Tim Starling <[email protected]> 2012-09-27 06:14:25 
UTC ---
It would be nice if it worked for sites other than Wikipedia. It seems a bit
funny to implement so many layers of abstraction and then to hard-code the site
name.

Global variables names should be prefixed with "wg", including configuration
globals. For example, $wbStores should be $wgWBStores.

The performance issue I identified during core review, i.e. O(N^2) write
queries for N link updates, seems to still be present. WikibaseCache.sql says
"this cache is a shared table, so exists only once per master", but I couldn't
find any actual implementation of that mechanism. EntityCacheTable does not
override the getReadDb() method or use a database selector in getName(). 

ChangesTable also appears to lack any remote DB support, so it's hard to see
how a change could propagate from one wiki to another. When I run
pollForChanges.php on a client wiki, it just gives me an error. No doubt you
would have tested that, so I'm probably just doing it wrong. But grepping for
wfGetLB() doesn't give any hits, and that is the obvious way to connect to a
remote DB.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to