https://bugzilla.wikimedia.org/show_bug.cgi?id=40542
Web browser: ---
Bug #: 40542
Summary: Passing constant via reference in Title.php
Product: MediaWiki
Version: 1.20-git
Platform: Other
OS/Version: Linux
Status: NEW
Severity: normal
Priority: Unprioritized
Component: General/Unknown
AssignedTo: [email protected]
ReportedBy: [email protected]
Classification: Unclassified
Mobile Platform: ---
cascade was passed as a constant, but it is expected to be a reference.
includes/Title.php line 2267
Untested Patch :
@@ -2263,7 +2263,8 @@ public function updateTitleProtection( $create_perm,
$reason, $expiry ) {
$expiry = array( 'create' => $expiry );
$page = WikiPage::factory( $this );
- $status = $page->doUpdateRestrictions( $limit, $expiry, false, $reason,
$wgUser );
+ $cascade=false;// passed by reference to doUpdateRestrictions, dont pass
constants
+ $status = $page->doUpdateRestrictions( $limit, $expiry, $cascade, $reason,
$wgUser );
return $status->isOK();
}
also here :
https://github.com/h4ck3rm1k3/mediawiki/commit/5cd7bccdb53389c8da58738924f10f9dc9465cb9
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
