https://bugzilla.wikimedia.org/show_bug.cgi?id=38334
Daniel Friesen <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mediawiki-bugs@nadir-seen-f | |ire.com --- Comment #10 from Daniel Friesen <[email protected]> 2012-10-01 17:55:52 UTC --- (In reply to comment #8) > Why am I suddenly responsible for this? > > (just wondering, I don't mind). > > To answer the question: No, PHP errors should not be acceptable, our unit > tests > should've caught it in which case whatever caused this couldn't have been > merged in the first place. > > However I'd rather not add isset() calls in Vector.php all over the place, it > should have a 'href' property at that point. So though the error comes from > that line, the problem is deeper. Maybe Niklas can provide a more elaborate > stack trace and dump the array in question to see what else is in it? (e.g. it > it contains 'text' => 'Thread', we'd know to look in LQT). The standard thing to do in skins is use wfSuppressWarnings(); and then at the end use wfRestoreWarnings(); For some reason Vector does not do that. ...I wonder if we should just code that into SkinTemplate itself. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
