https://bugzilla.wikimedia.org/show_bug.cgi?id=40541

--- Comment #9 from Chris Steipp <[email protected]> 2012-10-01 19:55:53 
UTC ---
(In reply to comment #8)
> Honestly, if MediaWiki is explicitly requesting an HTTPS link, I think it is
> erroneous to produce something different, especially with something as
> ambiguous as what $wgServer's scheme is. I think PROTO_HTTPS should give https
> regardless of $wgServer.

I totally agree, in theory. However, even when I do that, if I load a page over
ssl on a site where $wgServer starts with http://, all of the links to load.php
and api.php use http instead of https. So the assumption that $wgServer can be
used to generate urls with the correct protocol seems to be used all over the
place.

I tested out just setting $wgServer to be protocol-relative if $wgSecureLogin
is true, and it's working well. I don't like the idea of secretly flagging or
changing a user's config, but in this case it seems like it may make sense to
fix up conflicting config options?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to