https://bugzilla.wikimedia.org/show_bug.cgi?id=39957
--- Comment #3 from MZMcBride <[email protected]> 2012-10-08 13:13:41 UTC --- --- // If the number of watches exceeds the threshold, do not // require a permission. if ( $watchers >= $wgUnwatchedPageThreshold ) { $unwatchedAllowed = true; } // If allowed, add the statistic. if ( $unwatchedAllowed ) { $result['watchers'] = $watchers; } --- I think this is a bit weird. Does integer >= false really work? And why are you creating a separate branch after just creating this variable? Wouldn't doing all of this in a single if be cleaner? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
