https://bugzilla.wikimedia.org/show_bug.cgi?id=39399
--- Comment #13 from Andre Klapper <[email protected]> 2012-10-10 21:13:26 UTC --- The four keywords very likely predate Gerrit. "patch-in-gerrit" - without reading the description you don't know that you should remove this once the patch is *reviewed* in gerrit. It contains no information whether the review was positive or negative. "patch-need-review": Does not provide any info where the review is expected to take place. Bugzilla, Gerrit? "patch-reviewed": What does it mean at all and why is that interesting in Bugzilla in case the review took place in Gerrit? In case it's kind of relevant in Bugzilla, it does not tell you if the patch was accepted or not accepted. I've seen removal of the "patch" keyword together with removal of "patch-in-gerrit" and replacement by "patch-reviewed". What is the "patch" keyword there for at all if basically means the same as "patch-need-review" initially? General problem: Keywords are per bug report. A bug can have several patches attached and it's unclear what the keywords refer to. Last patch? All patches? Sounds rather like a usecase for a flag. Use the "patch" checkbox for patches (no need to duplicate info by a keyword), set review? flag to request review, get review+ or review- as feedback. All of course only if Bugzilla was used instead of Gerrit. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
