https://bugzilla.wikimedia.org/show_bug.cgi?id=41170
Daniel Kinzler <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected]. | |org, | |[email protected] | |ia.org Component|Database |WikidataRepo Version|1.21-git |unspecified AssignedTo|[email protected]. |[email protected] |org |ia.org Product|MediaWiki |MediaWiki extensions --- Comment #1 from Daniel Kinzler <[email protected]> 2012-10-18 13:38:05 UTC --- DatabaseUpdater::doUpdates wraps all updates in one big transaction (this was introduces by Iebb6855e, apparently to fix some issue with PG). If some DB update registered by an extension tries to open a transaction, that will cause these warnings (if you have $wgDevelopmentWarnings enabled). Wikibase\Utils::insertDefaultSites() does do that. There's two possible solutions: 1) remove the global spanning transaction. That seems to be prudent in the absence of support for nested transactions. But it may break whatever problem was fixed by Iebb6855e. 2) detect open transactions in Utils::insertDefaultSites(), and only open a transaction if there isn't one already. Also, I'm not sure why Utils::insertDefaultSites() needs a transaction at all. Consistency is not critical here. Is it a performance thing? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
