https://bugzilla.wikimedia.org/show_bug.cgi?id=37321
Krinkle <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Blocks|39801 | Resolution| |INVALID --- Comment #3 from Krinkle <[email protected]> 2012-10-22 21:15:34 UTC --- Instead of re-running a whole legion of asynchronous tests unrelated to i18n, any i18n related tests should test in multiple locales by executing their units correctly and passing whatever parameters necessary. There are many context related factors, "just" re-running everything in all sorts of combinations (uselang, skin, page existence, user logged-in state, mediawiki configuration variables, user preferences etc.) - units can do this themselves. We do this on most/all other factors already, and we can for i18n as well. See also bug 39801 comment #2: I243d055d demonstrates a way to run certain assertions in multiple locales by re-loading the mediawiki.language module. This isn't a magic way to re-run anything for a list of languages, but it does show that the mw object is dynamic and can be augmented at any time for any purpose. Other tests should implement their own way of running their logic for other languages. If that means re-loading mw.language, then that is a way. If that means addressing a lower-level method of that library directly, that works too. For example instead of changing wgUserLanguage and re-running $.foo.init() and asserting $.foo.bar(), sometimes it is better to do var myFoo = new $.Foo( { lang: code } ); and assert myFoo.bar(); Marking this bug as invalid as I don't believe re-running everything for an arbitrary of languages is a scalable or useful method. Instead test should be written in a testable way and will therefor be naturally be testable for affecting context factors, including but not limited to the language. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
