https://bugzilla.wikimedia.org/show_bug.cgi?id=41141
Krinkle <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #4 from Krinkle <[email protected]> 2012-10-25 21:07:26 UTC --- (In reply to comment #3) > MobileFrontend is driven by the needs of Wikimedia Foundation sites. We avoid > making it too WMF-centric where possible so it's usable/adaptable for others, > but we may sometimes introduce WMF-isms without being able to immediately > replace them with a more configurable/abstracted approach. Patchsets are > appreciated. (In reply to comment #2) > The distinction becomes relevant when evaluating how much sense it ever made > to > hardcode a ™ in the code. Even WMF doesn't have a ™ or ® on every single site name. This seems redundant anyway, we don't do it on desktop either (I know that doesn't mean by definition it isn't relevant for mobile, but it shows that if it was relevant, it would be provided in a generic way, not hardcoded in mobile first). So lets remove it from mobile. There is actually (almost) code for this in place already: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/MobileFrontend.git;a=blob;f=includes/skins/SkinMobile.php;h=2d7f7536def6fd55da7edc5932fa32e06bfd7520;hb=HEAD#l174 $wgMFCustomLogos['copyright'], just turn that from a url string into an associative array with img-src and text. Then show the text if no img-src, and show img-src with alt=text otherwise. And if wgMFCustomLogos is not set (default) don't show ™ or ® (instead of defaulting to ™). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
