https://bugzilla.wikimedia.org/show_bug.cgi?id=41428
--- Comment #8 from Ori Livneh <[email protected]> 2012-10-28 23:35:01 UTC --- (In reply to comment #7) > That said, is there a lesson here? Do we have automated JavaScript testing up > yet (I remember Testswarm working before the move, but haven't heard anything > since)? Yes. EventLogging is currently one of only five extensions (if http://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderTestModules is to be believed) that declare a JavaScript test suite to ResourceLoader for automated testing. I've written quite a few tests for it, but unfortunately, the comprehensiveness of the test suite gave me a false sense of confidence and I was lazy about testing the most recent change on older browsers. TestSwarm is not yet ready AFAIK, but we have a subscription for BrowserStack (http://www.browserstack.com/) that I could have and should have used. > How many manual tests are performed pre-deployment? Usually, quite a few. For this particular change set, not enough. > Is IE8 on that list (market share 10-20%)? Yes. > Should it be? Yes. > Should we have reverted even more quickly rather than trying to fix this > and/or waiting for a bit? I'm not sure that this was the precise sequence of events. AFAIK as soon as the culprit was identified, ^demon went ahead and disabled it. > Who can we ask/go to if we want to propose a straight revert? Ideally the developer / deployer responsible for rolling out the bug; failing that, anyone on #wikimedia-tech available to help. > I think we dropped the ball here, if only temporarily. Agreed. I'm responsible, and I'm sorry for being careless. In the future, I'll be more disciplined about running tests on a complete browser matrix as a precondition for merging / deploying code. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
