https://bugzilla.wikimedia.org/show_bug.cgi?id=41352
--- Comment #18 from Daniel Kinzler <[email protected]> 2012-10-29 15:48:22 UTC --- (In reply to comment #16) > ...and this line: > > $this->textbox1 = ContentHandler::getContentText( $contentObj ); > > ...was changed to: > > $this->textbox1 = ContentHandler::getContentText( $content ); > > Is that indeed what changed? If so, why does what you did fix this? No. Essentially, I replaced this: > if ( $this->mergeChangesIntoContent( $textbox_content ) ) { ... } By this: > if ( $this->mergeChangesIntoContent( $content ) ) { ... } The rest is just cleanup. $textbox_content is holding the content as submitted - for a section edit, just the content of the section. $content holds the full page content before the edit. mergeChangesIntoContent( $content ) merges the new changes into the old content, as it should be. mergeChangesIntoContent( $textbox_content ) merged the new changes into the new section content, which does not make sense, and also loses all content outside that section. This was a simple oversight - I got confused about which variable holds what and when. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
