https://bugzilla.wikimedia.org/show_bug.cgi?id=41323

TMg <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #2 from TMg <[email protected]> 2012-10-29 19:57:10 UTC ---
With the following code the "x" is positioned exactly as it is now.

.postedit-close {
  line-height: 2.3em;
  padding: 0 .8em;
  right: 0;
  top: 0;
}

The right position was 0.8em. I moved this to the padding.

The top position was 0.6em. I added this to the line-height (0.6em + 1.1em +
0.6em = 2.3em).

Slightly related: I saw that the resulting HTML code looks like <div
class="postedit-icon">this with the text inside the icon container</div>. I
don't think this is intended. The CSS contains a "line-height: 25px" for that
container which does make for the icon but not for the text. Everything else
uses "em". This makes the calculated height of the popup 0.6em (padding) + 25px
(line-height for a single line of text) + 0.6em (padding). Because of this mix
of "px" and "em" it's not really possible to center the "x".

You should use "em" everywhere except for the (empty) icon container.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to