https://bugzilla.wikimedia.org/show_bug.cgi?id=41855

       Web browser: ---
             Bug #: 41855
           Summary: Hard coding LIKE in db queries isn't database agnostic
           Product: MediaWiki extensions
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: Unprioritized
         Component: TimedMediaHandler
        AssignedTo: [email protected]
        ReportedBy: [email protected]
                CC: [email protected]
    Classification: Unclassified
   Mobile Platform: ---


In SpecialTimedMediaHandler:

    private $formats = array(
        'ogg' => 'img_name LIKE "%.ogv" OR img_name LIKE "%.ogg"',
        'webm' => 'img_name LIKE "%.webm"',
    );

Code like that isn't database agnostic. Should use $db->buildLike()

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to