https://bugzilla.wikimedia.org/show_bug.cgi?id=41100

--- Comment #6 from Aaron Schulz <aschulz4...@gmail.com> 2012-11-18 06:03:55 
UTC ---
(In reply to comment #3)
> There was more:
> 
> 2) MessageGroupStatesUpdaterJobTest::testHooks
> DBQueryError: A database error has occurred.  Did you forget to run
> maintenance/update.php after upgrading?  See:
> https://www.mediawiki.org/wiki/Manual:Upgrading#Run_the_update_script
> Query: UPDATE  `unittest_job` SET job_token =
> '2a19f741b629f083508dcbe2499a1c03',job_token_timestamp =
> '20121116185507',job_attempts = job_attempts+1 WHERE job_cmd =
> 'MessageGroupStatesUpdaterJob' AND job_id = '3' AND job_token = ''
> Function: JobQueueDB::claimRandom
> Error: 1054 Unknown column 'job_attempts' in 'field list' (localhost)

And? The commit message mentioned the change and
https://github.com/wikimedia/mediawiki-core/blob/master/RELEASE-NOTES-1.21
already mentions job queue schema changes (it would be odd to add another entry
since the whole job queue stuff was done in 1.21 so it makes no difference to
third parties).

Updating the code without running update.php will always have problems
sometimes. One could add wikitech-l comments...although that starts to become
more denormalization and busy work. Keeping an eye on
https://github.com/wikimedia/mediawiki-core/blob/master/includes/installer/MysqlUpdater.php
would be easier than watching the summaries of all commits. Maybe date comments
could be added there or something too.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to