https://bugzilla.wikimedia.org/show_bug.cgi?id=19509

           Summary: can't upload to file called '0'
           Product: MediaWiki
           Version: 1.16-svn
          Platform: All
        OS/Version: All
            Status: NEW
          Keywords: easy, need-review, patch
          Severity: minor
          Priority: Normal
         Component: Uploading
        AssignedTo: [email protected]
        ReportedBy: [email protected]


Created an attachment (id=6297)
 --> (https://bugzilla.wikimedia.org/attachment.cgi?id=6297)
patch for SpecialUpload.php (revision 52760)

When the destination filename in Special:Upload is set to '0', it's considered
to be unset, and the file is uploaded, using the filename of the source file as
the destination filename.  If the destination filename is '1', however, the
wiki warns that the destination doesn't have an extension.  This is because
$this->mDesiredDestName is used as a boolean several times in
SpecialUpload.php, where it would be more correct to test
($this->mDesiredDestName != ''), which flags both null and '' as empty values,
but not '0'.  This is a minor bug all right, but there it is.  It's present in
the newupload branch too.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to