https://bugzilla.wikimedia.org/show_bug.cgi?id=36348

--- Comment #13 from Krinkle <[email protected]> 2012-11-21 16:34:27 UTC ---
(In reply to comment #1)
> base64 encoded truncated md5? Not really what I'd pick for 'short' or
> 'intuitive'.
> 
> The string concatenation instead of modifying $attribs smells of bad coding
> style.
> 
> But more importantly. Taking over the <h#>'s id="" for this? That is a fairly
> short sighted decision. We have bugs open requesting that we move the existing
> id="" from the mw-headline to the <h#>. So I would reject this patch simply on
> those grounds.

I agree with Daniel, this seems very hacky and there is no clear use case. If
you want to create a short url, create a truly short url, not just the section
anchor (there are 100s of url shorteners out there, and Wikimedia is also
working on one of their own).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to