https://bugzilla.wikimedia.org/show_bug.cgi?id=42494

       Web browser: ---
             Bug #: 42494
           Summary: Don't run WRITE operations in ORMRowTest when testing
                    on a Client instance
           Product: MediaWiki extensions
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: WikidataClient
        AssignedTo: wikidata-b...@lists.wikimedia.org
        ReportedBy: tobias.gritschac...@wikimedia.de
                CC: wikibugs-l@lists.wikimedia.org,
                    wikidata-b...@lists.wikimedia.org
    Classification: Unclassified
   Mobile Platform: ---


>From E-Mail discussion:

Approach A:
"We could override the relevant test functions to skip the test if run on a
client setup. That detection could be implemented by defining a constant in
WikibaseClient.php (and a different constant in Wikibase.php). E.g. WB_CLIENT
and WB_REPO, or some such."

Approach B:
"Alternatively, split off the write tests from the read tests, and put the
write
test into the repo extension. ORMRowTest could take a flag in the constructor,
telling it whether write operations should be tested."

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to