https://bugzilla.wikimedia.org/show_bug.cgi?id=19557

           Summary: is_khtml can be triggered by Chrome with <!DOCTYPE html>
           Product: MediaWiki
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Keywords: need-review, patch
          Severity: minor
          Priority: Normal
         Component: General/Unknown
        AssignedTo: [email protected]
        ReportedBy: [email protected]


Created an attachment (id=6302)
 --> (https://bugzilla.wikimedia.org/attachment.cgi?id=6302)
Add navigator.accentColorName to KDE detection in wikibits.js

When <!DOCTYPE html> is used (yes, I know . . .), the is_khtml compatibility
variable in wikibits.js is activated by Google Chrome. This misdetection
results in the KHTML fix stylesheet being applied, including this rule:
#column-content { margin-left: 0; }

Unfortunately this prevents the portlets from floating on the left; instead,
they appear on the left but beneath the page content.

http://www.webreference.com/programming/javascript/sniffing/2.html suggested
that the presence of navigator.accentColorName could be used to distinguish
between Konquerer and Safari (or rather KHTML and Webkit, hence including
Chrome). I added this to is_khtml, the stylesheet was no longer loaded, and the
problem disappeared.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to