https://bugzilla.wikimedia.org/show_bug.cgi?id=19546


Splarka <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |




--- Comment #3 from Splarka <[email protected]>  2009-07-07 00:38:39 UTC ---
> Fixed this logic to do proper skin detection in r52821.

Yes the original code was bad, but this is worse. >_<

This presumably breaks it in chick, myskin, and simple, as well as any other
user-defined monobook+template skins, which use the same HTML as Monobook (and
are basically "Monobook" skins), but have a different name. You shouldn't rely
on a js-based skin-name check, but fix the underlying problems with vector. Or
do what the code suggests:
        // We special-case skin structures provided by the software.  Skins
that
        // choose to abandon or significantly modify our formatting can just
define
        // an mw-js-message div to start with.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to