https://bugzilla.wikimedia.org/show_bug.cgi?id=19004
Roan Kattouw <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #5 from Roan Kattouw <[email protected]> 2009-07-10 15:44:23 UTC --- (In reply to comment #3) > Created an attachment (id=6314) --> (https://bugzilla.wikimedia.org/attachment.cgi?id=6314) [details] > patch against r53005 > > * adds list=tags > * adds 'tags' as an option for rcprop, rvprop, ucprop and leprop > > Haven't done filtering by tag. > Patch looks good overall, some more comments in addition to Bryan's: * You're querying the change_tag table using GROUP BY and COUNT(*). This is probably inefficient, so I recommend using valid_tags instead if at all possible * I don't see enough context in the patch, but you should test the LEFT JOINs you've added to make sure they don't try to join against the wrong table * The copyright notice in ApiQueryTags should include the author's name * Instead of 'continue' => array(), use 'continue' => null, same for 'end'. Also, 'end' is undocumented -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
