https://bugzilla.wikimedia.org/show_bug.cgi?id=19646
Summary: Localization of img_auth.php - with enhancements
Product: MediaWiki
Version: 1.16-svn
Platform: All
OS/Version: All
Status: NEW
Severity: enhancement
Priority: Normal
Component: Images and files
AssignedTo: [email protected]
ReportedBy: [email protected]
Created an attachment (id=6320)
--> (https://bugzilla.wikimedia.org/attachment.cgi?id=6320)
Updated img_auth.php
This started with localizing the messages with img_auth.php but expanded.
1. Localize img_auth.php using img_auth.i18.php and current EN language
2. Reorder checks to make sense (and eliminate redundancy). New order of
checks should be:
* See if this is a public Wiki (no protections)
* See if server allows PATH_INFO
* Basic directory traversal check
* See if could create the title object
* Check to see if the file exists
* Check to see if tried to access a directory
* See if could create the title object
* Run hook for extended checks
* Check user authorization for this title (UserCan)
* Whitelist check was deprecated - redundant to UserCan
3. Add a hook to allow custom checking for Custom FileRepo(s)
4. Add a global variable wgImgAuthDetails (img_auth only) that defaults to
minimum info, but allows
Details if set to true
5. Move all "wfDebugLog" into the rejection functions - since they should never
get there anyway.
This really cleans up the script file and with the hook and localization should
minimize future maintenance.
I've tested to the extent that I can in my environment, but really need code
check and other testers.
Would also do documentation.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
