https://bugzilla.wikimedia.org/show_bug.cgi?id=42928
Rainer Rillke @commons.wikimedia <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|ResourceLoader |TimedMediaHandler Assignee|[email protected]. |[email protected] |org | Product|MediaWiki |MediaWiki extensions Severity|minor |enhancement --- Comment #6 from Rainer Rillke @commons.wikimedia <[email protected]> --- > What bugs? Was a default text I used while writing bug reports about mwEmbed or TMH. > Mediawiki currently still registers all config options as global variables Yes. But this is not a reason not to put all your config stuff into *a single variable*, an *object* consisting of *properties*. If this is not possible in LocalSettings.php, it seems to be superior design to put it in something like UploadWizard.config.php (so TMH.config.php) If UploadWizard does it (yes it has *one global variable* with _all its config in it_), there must be a way. Why else should you do this? Of course to save transfer volume. If you make variables like these, their name will be always written as full strings into JavaScript. And when accessing them, it is also likely that you use the full string or some strange hack to avoid it. Furthermore, these strings can't be replaced when you e.g. decide to introduce code compression (closure compiler) while when doing something like suggested in #c0, "EmbedPlayer" can be shortened to 1 char. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
