https://bugzilla.wikimedia.org/show_bug.cgi?id=16165
Krinkle <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|Normal |Lowest CC| |[email protected] --- Comment #50 from Krinkle <[email protected]> --- In response to Change-Id: I1b8051549edcc5bccadbc89253daadefcdbcfe0d (Patch set 5) -- We don't use jQuery UI buttons anywhere in core, this it not the place to "randomly" start using them. It would be the only button anywhere that uses this style. There are some people working on stylesheets that will allow a consistent styling between links and buttons (to not require visual distinction for cases where it doesn't make sense to the user), but avoid adding more inconsistency. The use case of opening the diff in a new window is valid, but rare (mostly for power users). However, regardless of the target audience, this contradicts the expectation pattern it claims to solve. People know that form submission can't be "opened" in a new window, only links or target buttons can be opened in a new window (The Issue page on GitHub is a good example. The Pull request button and other buttons on top look like buttons but are <a> links. The form submit button, looking similar, is not a link because it submits a form. The user is aware of that and it works intuitively.). This diff button is a grey area. It UX is not like a form submission, but not like a plain link either. But whatever the case, by making it the only button in MediaWiki that can be "opened" in a new window, is that an improvement? Users would still be expecting the same (a button can't be opened in a new window). So it wouldn't really solve anything. And then there is consistency, why only this button and not the 100s other butons in MediaWiki? Again, a valid use case, but not something that should be duck-punched locally in one specific module. And besides, it is a very trivial case. The information is accessible, the page can be opened, just not with the ability to right-click it as a link. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
