https://bugzilla.wikimedia.org/show_bug.cgi?id=19704
Summary: improve/fix CentralNotice style loading
Product: MediaWiki extensions
Version: any
Platform: All
OS/Version: All
Status: NEW
Severity: trivial
Priority: Normal
Component: CentralNotice
AssignedTo: [email protected]
ReportedBy: [email protected]
Currently CentralNotice drops a <style> tag in via
"document.writeln($encShowStyle);" from an offsite script. In some older
browser engines this can arbitrarily drop the style tag almost anywhere in the
dom (including the textarea). A document.writeln() should not be performed via
offsite script due to the unpredictablility of exactly when it will execute.
This should be changed to an appendCSS() call (a core feature in wikibits.js
since 1.13, and using proper DOM methods) or such.
Also, is this CSS strictly necessary if the notice has been dismissed or has
been overwritten locally? Can this appendCSS call be moved inside the
"if(wgNotice != '')" scope below?
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
