https://bugzilla.wikimedia.org/show_bug.cgi?id=19621
--- Comment #5 from Roan Kattouw <[email protected]> 2009-07-14 13:08:49 UTC --- (In reply to comment #4) > (In reply to comment #3) > > That shouldn't work. If it does, that's an SQL injection vulnerability. > > > > Is it not rather a selection than an injection; indeed that query does not > change the DB: > > 'SELECT ... FROM ... WHERE rev_page=page_id AND page_namespace=0 AND > page_is_redirect=0' > I don't think you understand. It should not be possible to inject SQL through form fields EVER, or someone will find a way to exploit it. To fix this, you should use "AND page_namespace " . $db->addQuotes( $ns ) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
