https://bugzilla.wikimedia.org/show_bug.cgi?id=43510

       Web browser: ---
            Bug ID: 43510
           Summary: jqueryMsg can not handle external links with dollar
                    signs in the URL
           Product: MediaWiki
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: JavaScript
          Assignee: [email protected]
          Reporter: [email protected]
                CC: [email protected], [email protected]
    Classification: Unclassified
   Mobile Platform: ---

mediawiki.jqueryMsg can not handle external links with dollar signs in the URL.
 However, those are valid.  See bug 188 and
https://en.wikipedia.org/wiki/MediaWiki:Version-entrypoints-articlepath .

External links are defined as:

sequence(openExtlink, nonWhitespaceExpression, whitespace, expression,
closeExtlink)

So the URL must go in nonWhitespaceExpression.  That in turn is:

choice(template, link, extLinkParam, extlink, replacement, literalWithoutSpace)

This seems overly broad, since I don't think we allow nested external links...
However, the one that should match is literalWithoutSpace.

That is nOrMore( 1, escapedOrLiteralWithoutSpace )

escapedOrLiteralWithoutSpace is:

choice(escapedLiteral, regularLiteralWithoutSpace)

So I think the root problem is regularLiteralWithoutSpace, which is:

makeRegexParser(/^[^{}\[\]$\s]/);

I think this should allow $, which means removing it from the negative
character class.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to