https://bugzilla.wikimedia.org/show_bug.cgi?id=35993

Yuri Astrakhan <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #5 from Yuri Astrakhan <[email protected]> ---
A bit confused by the tokens implementation - there is a needsToken() which
appears useless except to generate some help string, and yet many modules
diligently override it.
Also, in ApiMain.php / setupModule() has this line
 if ( $salt !== false && !$gettoken ) ...
doesn't php give false when gettoken is ''?
Lastly, the isset( $moduleParams['token'] ) - wouldn't that be always true even
if the user didn't pass value (will be equal to null).
Thx!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to