https://bugzilla.wikimedia.org/show_bug.cgi?id=42412
--- Comment #6 from Bawolff (Brian Wolff) <[email protected]> --- I just realized I said some incorrect things in comment 3. (In reply to comment #3) > > With the actual patch, the getFirstLetter takes a binary string. There's no > guarantee that the icu collation won't use a binary code that is also a code > point for one of the "polish" letters (in practise that's probably rare > though). Additionally since its a binary string, its not guaranteed to be > valid > UTF-8, and I'm not sure how mb_substr would handle invalid utf-8. This is all incorrect. getFirstLetter takes the human readable sortkey. >This makes the attachment essentially useless. Not entirely useless, after all the patch works now, where we don't have .ser files for pl yet. But Ideally we'd be doing this with the .ser file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
