https://bugzilla.wikimedia.org/show_bug.cgi?id=43740

--- Comment #3 from Bawolff (Brian Wolff) <[email protected]> ---
(In reply to comment #2)
> It looks kind of like the code in Collation.php
> 
>     // Primary collision
>     // Keep whichever one sorts first in the main collator
>     if ( $this->mainCollator->compare( $letter, $letterMap[$key] ) < 0 ) {
>              $letterMap[$key] = $letter;
>     }
> 
> Was meant to handle this situation (or I misunderstand the intention of the
> code)

So reason that block of code didnt prevent the appearant primary key collisions
caused by the icu version mismatch was because they weren't collisions.  The
two cases I saw were a rupee header in the middle of the r section and an A/S
symbol in the middle of the a's. Both cases the symbols would be expanded to
have more than one primary weight-so they weren't exact collisions, only a
prefix was equal

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to