https://bugzilla.wikimedia.org/show_bug.cgi?id=44113
Web browser: ---
Bug ID: 44113
Summary: http proxy support broken
Product: MediaWiki
Version: 1.20.2
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Unprioritized
Component: General/Unknown
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected]
Classification: Unclassified
Mobile Platform: ---
The change from Wed, 29 Feb 2012 in includes/HttpFunction.php broke mediawiki’s
proxy support.
see
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=commitdiff;h=1d065d50f63676e081b0101f849aaa0249b950c7;hp=2730e89017079d4675a8ef9d353255661a03a112
in function proxySetup()
- if ( $this->proxy && !$this->noProxy ) {
If there is a proxy set AND we should NOT USE proxy then return instantly
without setting a proxy.
That sounds reasonable.
+ if ( $this->proxy || !$this->noProxy ) {
If there is a proxy set OR we should NOT USE proxy then return instantly
without setting a proxy.
(Correctly) Applying De_Morgan's laws we get:
If there is a proxy set AND we should NOT NOT USE proxy then return instantly
without setting a proxy.
Simplifying we get:
If there is a proxy set AND we should USE proxy then return instantly without
setting a proxy.
That doesn’t make any sense.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
