https://bugzilla.wikimedia.org/show_bug.cgi?id=23343

--- Comment #41 from Chris Steipp <[email protected]> ---
Going back to comment #16, and what to do when multiple blocks apply to the
same request, I added some logic to gerrit I3e38b94d so that:
 * Blocks that match the block's target IP are preferred over ones in a range
 * Hardblocks are chosen over softblocks that prevent account creation
 * Softblocks that prevent account creation are chosen over other softblocks
 * Other softblocks are chosen over autoblocks
 * If there are multiple exact or range blocks at the same level, the one
closer
   (less hopps) to the server is chosen


So for some examples, I have:
* 50.1.1.1 - softblock
* 50.2.0.0/16 - softblock
* 60.2.0.0/16 - softblock with account creation disabled
* 70.2.0.0/16 - hardblock

XFF: 1.2.3.4, 70.2.1.1, 60.2.1.1, 2.3.4.5 => Hardblock
XFF: 1.2.3.4, 50.2.1.1, 60.2.1.1, 2.3.4.5 => Softblock w/ AC disabled
XFF: 1.2.3.4, 70.2.1.1, 50.1.1.1, 2.3.4.5 => Softblock

Does this seem reasonable? I'm happy to update the logic, that just seemed like
it would give the strongest block, while still allowing a Steward to target an
IP (with an exact match instead of a range) if a single IP in a range block is
behaving more appropriately than others.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to