https://bugzilla.wikimedia.org/show_bug.cgi?id=44344

       Web browser: ---
            Bug ID: 44344
           Summary: Loading site links needs optimization
           Product: MediaWiki extensions
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: WikidataClient
          Assignee: [email protected]
          Reporter: [email protected]
                CC: [email protected],
                    [email protected]
    Classification: Unclassified
   Mobile Platform: ---

When the sites data cache is reset, it is super slow to load the site links. 
The code for adding the interwiki language links could use optimization in this
case, and optimizations may also be helpful for when sites data comes from
memcached.

I have this test wiki on external hosted VM which is reasonably fast most of
the time for most stuff, but not this.

My profiling without stuff in memcached:

Wikibase\ClientHooks::onParserAfterParse
76.56%    7.02%    4    0.36    11606.12    860.34    4220.41    312.85
Wikibase\LangLinkHandler::addLinksFromRepository
76.55%    6.41%    1    0.09    46416.9    3144.88    4219.72    285.9
SiteSQLStore::getSite [+]
76.41%    40.07%    11    1    4211.72    1786.12    4211.72    1786.12
SiteSQLStore::loadSites
76.23%    40.04%    7    0.64    6602.97    2804.92    4201.89    1784.95
Wikibase\LangLinkHandler::getEffectiveRepoLinks
69.68%    0.63%    1    0.09    42252.8    307.8    3841.16    27.98
Wikibase\LangLinkHandler::getEntityLinks
69.68%    0.67%    1    0.09    42251    329.06    3841    29.91
SiteSQLStore::siteFromRow
15.62%    16.1%    5495    499.55    1.72    1.44    860.76    717.85

With memcached:

Wikibase\ClientHooks::onParserAfterParse
61.84%    3.93%    6    0.29    7929.48    573.7    2265.57    163.91
Wikibase\LangLinkHandler::addLinksFromRepository
61.83%    3.59%    1    0.05    47566.8    3145.11    2265.09    149.77
SiteSQLStore::getSite [+]
61.71%    22.41%    11    0.52    4315.88    1786.15    2260.7    935.6
SiteSQLStore::loadSites
61.56%    22.4%    7    0.33    6765.61    2804.95    2255.2    934.98
Wikibase\LangLinkHandler::getEffectiveRepoLinks
55.27%    0.35%    1    0.05    42524.4    307.99    2024.97    14.67
Wikibase\LangLinkHandler::getEntityLinks
55.27%    0.38%    1    0.05    42521.7    329.25    2024.84    15.68
Setup.php [+]
15.66%    23.76%    21    1    573.57    992.03    573.57    992.03
SiteSQLStore::siteFromRow
12.72%    9.01%    5495    261.67    1.78    1.44    465.88    376.01


Things seemed to be faster before the latest sites code changes, although I
think optimizations were needed anyway and needed even more now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to