https://bugzilla.wikimedia.org/show_bug.cgi?id=44346

       Web browser: ---
            Bug ID: 44346
           Summary: PingLimiter hook cannot override result.
           Product: MediaWiki
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: General/Unknown
          Assignee: [email protected]
          Reporter: [email protected]
                CC: [email protected]
    Classification: Unclassified
   Mobile Platform: ---

The PingLimiter hooks allows extensions to override throttles for a user. If
you look at the docs (http://www.mediawiki.org/wiki/Manual:Hooks/PingLimiter),
you'll see the third parameter (the output result of the ping limiting) is a
reference. This makes sense.

However, if you look at the code, it's actually not passed as a reference,
which means extensions are quite literally passed a useless parameter that is
set to false always.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to