https://bugzilla.wikimedia.org/show_bug.cgi?id=19847


Roan Kattouw <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]




--- Comment #4 from Roan Kattouw <[email protected]>  2009-07-25 15:32:21 
UTC ---
(In reply to comment #3)
> Hmm, I doubt this is the jquery problem. As a matter of fact, now that the 
> page
> is loaded for minutes, it still doesn't work.
> 
> If i run it from console I still get
> > jQuery( 'div#edittoolbar' ).toolbar
> undefined
> 
> So that means that toolbar has failed to have been setup earlier, probably
> silently failing. 
> I did not that there are a lot of for(in) construct in the EditToolbar.js 
> These
> are known to be a problem esp. on Safari and Chrome, because Safari doesn't
> safeguard the user from extended objects (and this is actually correct
> behaviour). So for(in) will give you EVERYTHING (it is an object iterator) and
> is not guaranteed to be the same as for( i=0; i<something.length i++ )  (an
> array iterator). Basically, wherever you have a .length, the usage of for(in)
> should be avoided, especially when you are extending objects and using jQuery.
> 
> This might also be related to the issue where the "Help" is showing "undefined
> undefined undefined". 
> 
Off the top of my head, we only use for(in) on objects that we define ourselves
and aren't related to jQuery, so we should be safe there.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to