https://bugzilla.wikimedia.org/show_bug.cgi?id=44801

       Web browser: ---
            Bug ID: 44801
           Summary: Reviewing new account request on isDeleted()
           Product: MediaWiki extensions
           Version: REL1_19 branch
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Unprioritized
         Component: ConfirmAccount
          Assignee: [email protected]
          Reporter: [email protected]
                CC: [email protected]
    Classification: Unclassified
   Mobile Platform: ---

frontend/specialpages/actions/ConfirmAccount_body.php
-----8<--------------------------------------------------------------
        protected function showAccountConfirmForm( $msg = '' ) {
                global $wgAccountRequestTypes;

                $out = $this->getOutput();
                $reqUser = $this->getUser();
                $titleObj = $this->getFullTitle();

                $accountReq = $this->accountReq; // convenience
                if ( !$accountReq || $accountReq->isDeleted &&
!$this->showRejects ) {
                        $out->addHTML( wfMsgHtml('confirmaccount-badid') );
                        $out->returnToMain( true, $titleObj );
                        return;
                }
----->8----------------------------------------------------------


my postgresql has a column:

 acr_deleted             | boolean                  | not null default false


and regardless that particular request is false, it doesn't get reviewed
because isDeleted() is true. Is that supposed to be a instance attribute / ORM
mapping or a function call? Because treating it as an attribute, it starts
working correctly. But I didn't track down its guts, how the instance gets
built and what that class contains.

Note that this is 119 branch git checkout.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to