https://bugzilla.wikimedia.org/show_bug.cgi?id=44846

Antoine "hashar" Musso <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

--- Comment #4 from Antoine "hashar" Musso <[email protected]> ---
I have decorrelated the php lint and jshint Jenkins jobs:
https://gerrit.wikimedia.org/r/#/c/48422/ (JJB)
https://gerrit.wikimedia.org/r/#/c/48423/ (Zuul)

Then made it so the mediawiki-core-jslint job is triggered for any branch NOT
matching 'REL1_19' with https://gerrit.wikimedia.org/r/#/c/48427/.  I slightly
tweaked it later with https://gerrit.wikimedia.org/r/48431 .

Testing the change in production gives out:

Testing out a change made against REL1_19 shows no jslint job:


Pipeline: check
---------------
Project mediawiki/core change 48428,1
  mediawiki-core-merge: None
  mediawiki-core-whitespaces: None (non-voting)
  mediawiki-core-phpcs-HEAD: None (non-voting)
  mediawiki-core-lint: None

Pipeline: test
--------------
Project mediawiki/core change 48428,1
  mediawiki-core-merge: None
  mediawiki-core-phpcs-HEAD: None (non-voting)
  mediawiki-core-lint: None
  mediawiki-core-phpunit-databaseless: None
  mediawiki-core-install-sqlite: None
  mediawiki-core-phpunit-api: None
  mediawiki-core-phpunit-misc: None
  mediawiki-core-phpunit-parser: None


Against REL1_20:

Pipeline: check
---------------
Project mediawiki/core change 48424,3
  mediawiki-core-merge: None
  mediawiki-core-whitespaces: None (non-voting)
  mediawiki-core-phpcs-HEAD: None (non-voting)
  mediawiki-core-jslint: None (non-voting)
  mediawiki-core-lint: None


Pipeline: test
--------------
Project mediawiki/core change 48424,3
  mediawiki-core-merge: SUCCESS
  mediawiki-core-phpcs-HEAD: None (non-voting)
  mediawiki-core-jslint: None (non-voting)
  mediawiki-core-lint: None
  mediawiki-core-phpunit-databaseless: None
  mediawiki-core-install-sqlite: None
  mediawiki-core-phpunit-api: None
  mediawiki-core-phpunit-misc: None
  mediawiki-core-phpunit-parser: None

And on master branch:

Pipeline: check
---------------
Project mediawiki/core change 48027,7
  mediawiki-core-merge: None
  mediawiki-core-whitespaces: None (non-voting)
  mediawiki-core-phpcs-HEAD: None (non-voting)
  mediawiki-core-jslint: None (non-voting)
  mediawiki-core-lint: None

Pipeline: test
--------------
Project mediawiki/core change 48027,7
  mediawiki-core-merge: None
  mediawiki-core-phpcs-HEAD: None (non-voting)
  mediawiki-core-jslint: None (non-voting)
  mediawiki-core-lint: None
  mediawiki-core-phpunit-databaseless: None
  mediawiki-core-install-sqlite: None
  mediawiki-core-phpunit-api: None
  mediawiki-core-phpunit-misc: None
  mediawiki-core-phpunit-parser: None


So we do not trigger JSHint anymore on REL1_19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to