https://bugzilla.wikimedia.org/show_bug.cgi?id=42715
Siebrand <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugzilla.wikimedia. | |org/show_bug.cgi?id=44960, | |https://bugzilla.wikimedia. | |org/show_bug.cgi?id=44962, | |https://bugzilla.wikimedia. | |org/show_bug.cgi?id=44963 --- Comment #31 from Siebrand <[email protected]> --- Timeline: 16:09 UTC Reported by Tilman in comment 24 18:09 UTC Report noticed by Siebrand (22:39 IST local time) 19:03 UTC First patch set with fix, Gerrit 48852 19:07 UTC Second patch set based on Siebrand's review 19:17 UTC Aaron reviews and approves 19:18 UTC Patch merged 19:24 UTC Patch backported to 1.21wmf9 by Aaron, Gerrit 48853 19:26 UTC Patch merged in 1.21wmf9 19:30 UTC Patch deployed on Wikimedia wikis running 1.21wmf9 (http://hexm.de/victory ) Based on this issue, I have also checked the return values of other Job::run() functions in the 188 extensions I have on my local machine. Luckily, jobs aren't used all over the place, so I was only able to locate 3 extensions with bugs, next to Translate which was already fixed by Niklas in Gerrit 48852. I reported bug 44960 (AFTv5), bug 44962 (Wikidata) and bug 44963 (TMH). To minimise damage from incorrect jobs, Aaron and I have also made changes to job queue: * Gerrit 48860 treats a non-boolean return value of Job::run() as true * Gerrit 48858 makes sure MediaWiki starts yelling if a job's run() method does not return a boolean. 1h11m as time to fix from "issue noticed" to deployment, while the report was noticed at 22:39 IST isn't bad at all, I think. Thanks to all involved! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
