https://bugzilla.wikimedia.org/show_bug.cgi?id=44768
[email protected] changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #3 from [email protected] --- This is a failure is really in his bot, not in the baserevid. What happens is that he tries to add a set of data values that contains sitelinks, labels, descriptions and aliases. This does a partial save and he gets a failure after the save completes. As he says he adds information during the save operation. After the failure he resends the same request, without doing a reload. During second and third save attempt only the aliases are stored. The reason is that he adds to the existing set. The add operation is unconditional and will not check for unique values, it just adds the new values and the bot says it should do so. In my opinion the correct behavior for the bot would be to reload and inspect the data returned when something like this happen. If we change the behavior to a conditional add, and only accept unique values, then duplicates should be removed before a successful save can be completed. Handling some violating entries while new violations can't be added is counterituitive and should be avoided. An option could be to remove non-unique entries silently, both on save and on load, but I'm not sure we can do that without loosing some error messages that otherwise should be returned. For that to work it would mean to remove all non-unique entries in EntityView, ApiGetEntities, ApiSetAliases and ApiEditEntity. I don't think we should change Entity to handle this error condition, that one should not have the responsibility to clean up user data. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
