https://bugzilla.wikimedia.org/show_bug.cgi?id=45229
Krinkle <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|Unprioritized |Low Severity|normal |enhancement --- Comment #4 from Krinkle <[email protected]> --- (In reply to comment #3) > (In reply to comment #1) > > There may be a way to address this, but in general you shouldn't use > > addModuleStyles and other mw.loader-circumventing methods in OutputPage. > > addModules loads stylesheets via JavaScript. This is absolutely unacceptable > for the css loaded by skins. Hence addModuleStyles has been used from the > start. > > And this is a problem for the entire interface, not the installer. I agree that's unacceptable for the skin. However if there's no dynamic client scripting involved, it means no dependencies can be resolved since we don't do that server side (not yet anyway). So in the current system, addModuleStyles doesn't (nor claims to) support dependencies. It adds that one module as a raw stylesheet to the page. As a short term fix it may help (not saying it is pretty, but it may improve the situation) to at least preserve the order in which the addModuleStyles() calls occurred, as generally these sort of things match execution order. e.g. { parent::myMethod(); // adds module $out->addModuleStyles( .. ); } -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
