https://bugzilla.wikimedia.org/show_bug.cgi?id=45282
--- Comment #3 from Daniel Kinzler <daniel.kinz...@wikimedia.de> --- @jeblad: you are right, I also noticed that when poking at the issue yesterday. The problem seems to be that SiteLinkTable's interface is a bit asymmetric: it stores information from SiteLink objects, but for queries, it takes a site ID and page title as a string. That is convenient, but introduces inconsistencies. Perhaps the necessary normalization should be done in the SiteLink class, and we should use SiteLink instances for querying the SiteLinkTable. But even the SiteLink class doesn't have the necessary information (namely, whether the target is a mediaWiki instance). That would have to be done in the Site object. So, this is my current take on the issue: * Site::normalizePageName() should get an option for enabling/disabling expensive canonical normalization. This is a core change. * SiteLinkTable should not take site id and page title as strings, but always operate on SiteLink instances. * SiteLink should provide way to create an instance with or without "expensive" normalization, and apply "cheap" normalization always. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
