https://bugzilla.wikimedia.org/show_bug.cgi?id=44547
[email protected] changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tobias.gritschacher@wikimed | |ia.de --- Comment #2 from [email protected] --- Tried the following example: * I have an item with 2 claims: claim A and claim B which both have a reference * I change the reference of claim A * I try to change the reference of claim B (without reloading the page): this fails What happens: * the request fails, because EditEntity::fixEditConflict() returns false in line 481. * of course the problem lies deeper, so I tracked it down a bit more * in line 468 of EditEntity::fixEditConflict() $patchedCurrent seems to contain wrong data: Claim B still has the old reference although it should have been patched with the Diff between the baseContent and the newContent (which still is correct - line 458). * consequently this leads to the case where the currentContent and the patched currentContent are the same and diffing them results in an empty diff which then leads to the patch collapsing. * going even further, in line 855 of Entity::patch() both parameters (array of claims of current content & the claimsDiff) seem to be correct, so I assume the problem might be somewhere deeper in the MapPatcher of the Diff extension -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
