https://bugzilla.wikimedia.org/show_bug.cgi?id=42441
Tim Starling <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |[email protected] Resolution|FIXED |--- --- Comment #20 from Tim Starling <[email protected]> --- I think the way the bug was fixed was not the right way to do it. For one thing, the documentation is now incorrect: * - sslVerifyHost (curl only) Set to 2 to verify hostname against certificate * Setting to 1 (or true) will NOT verify the host name. It will * only check its existence. Setting to 0 (or false) disables entirely. It should say that if you set it to 1 or true, it will throw a fatal error after curl 7.28.1. But that's a ridiculous convention. The option to Http::request() should have been left as it was, true for enabling, false for disabling, and that should have been converted to whatever curl (or whatever other backend we use) needs, i.e. 0 or 2. It's lucky that the callers only either set that parameter to false or omit it. If any set it to true, they would have been badly broken by this change. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
