https://bugzilla.wikimedia.org/show_bug.cgi?id=45590
Web browser: ---
Bug ID: 45590
Summary: VisualEditor: 'generated' property should not be
preserved when unwrapping
Product: VisualEditor
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: Data Model
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected], [email protected],
[email protected]
Classification: Unclassified
Mobile Platform: ---
When we unwrap lists, we currently preserve the internal 'generated' property
on paragraphs inside those lists, but we really shouldn't. The fact that we
don't currently clear this when unwrapping results in the following serious
bug:
1. Create a page with the following content
Foo
Bar
* Baz
* Quux
* Whee
Yay
2. Open the page in VE
3. Select across the three list items and click the list button to unlist them
4. VE now shows five paragraphs
5. Click "Review and save" and observe the diff.
Expected diff: the asterisk and space before "Baz", "Quux" and "Whee" are
removed.
Actual diff: the second line becomes "BarBazQuuxWhee", followed by three blank
lines, then "Yay".
This happens because the converter unwraps paragraphs with the 'internal': {
'generated': 'wrapper' } property, even if these paragraphs now appear in a
different context and even if there are multiple such paragraphs adjacent to
each other.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
