https://bugzilla.wikimedia.org/show_bug.cgi?id=45715
Web browser: ---
Bug ID: 45715
Summary: l10n bot should probably not self merge
Product: MediaWiki extensions
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: Translate
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected], [email protected],
[email protected], [email protected],
[email protected]
Classification: Unclassified
Mobile Platform: ---
The change https://gerrit.wikimedia.org/r/#/c/51900/ is a faulty update of the
mediawiki core message file for the AR language. All messages have been removed
from the file.
Since the l10n-bot vote CR+2 / V+2 and then submit the patch, the unit tests
are entirely bypassed.
Marius Hoch proposed to white list l10n-bot so tests are run on submission:
https://gerrit.wikimedia.org/r/#/c/51972/ . I guess we should just run the gate
and submit job instead. The workflow would thus need to be updated to
something like:
- l10n-bot send the patch
- jenkins run the check scripts (just linting, no unit tests)
- l10n-bot votes CR+2
- jenkins trigger the gate-and-submit job
- whenever the tests are successful, jenkins merge the change
That would let us catch regressions before landing changes in master.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l