https://bugzilla.wikimedia.org/show_bug.cgi?id=45684
--- Comment #8 from Tim Starling <[email protected]> --- (In reply to comment #3) > One of the problems that Lua scripting was intended to solve was that the > weather box rendering template should not take 50 seconds to render and there > is no reason on Earth why it should render as nearly as slow as this. I mean, > that's approximately 3 seconds per template. That's like processing one > weather > box is just as complex as transcoding ~10 seconds of Full HD video using > x264, > which is completely untrue and just blows my mind in a very negative sense of > this word. I think the concerns about migration complexity are valid. If you're replacing {{strlen}} with Lua, it's not really possible to know how long the arguments will take to expand, in all the thousands of existing callers. So there's no way the bug can reasonably be addressed by the developer of the relevant Lua module. I don't want to increase the timeout to something approaching the length of time it takes to parse an existing long page, because I think that would lead to permanent negative consequences for user experience. I don't want to exclude all PHP function calls from the usage timer, since that would open up DoS vulnerabilities, where the an expensive PHP function is called repeatedly in a Lua tight loop. I think excluding only getExpandedArgument() is a reasonable compromise. The results are cached by the PPFrame object, so a DoS attack against it would basically equivalent to one done with pure templates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
